Support db_securityadmin #100
Merged
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Lunagariya <[email protected]>
Signed-off-by: Harsh Lunagariya <[email protected]>
Signed-off-by: Harsh Lunagariya <[email protected]>
1 task
tanscorpio7
requested changes
Oct 22, 2024
Deepesh125
requested changes
Oct 22, 2024
src/bin/pg_dump/dump_babel_utils.c
Outdated
Comment on lines
55
to
58
| static char *default_bbf_db_principals = | ||
| "('master_dbo', 'master_db_owner', 'master_guest', 'master_db_accessadmin', " | ||
| "'msdb_dbo', 'msdb_db_owner', 'msdb_guest', 'msdb_db_accessadmin', " | ||
| "'tempdb_dbo', 'tempdb_db_owner', 'tempdb_guest', 'tempdb_db_accessadmin') "; | ||
| "('master_dbo', 'master_db_owner', 'master_guest', 'master_db_accessadmin', 'master_db_securityadmin', " | ||
| "'msdb_dbo', 'msdb_db_owner', 'msdb_guest', 'msdb_db_accessadmin', 'msdb_db_securityadmin', " | ||
| "'tempdb_dbo', 'tempdb_db_owner', 'tempdb_guest', 'tempdb_db_accessadmin', 'tempdb_db_securityadmin') "; |
There was a problem hiding this comment.
Instead of updating this static list everytime, is it possible to get this list dynamically using some query during dump? same is applicable for default_bbf_roles
There was a problem hiding this comment.
It should be possible IMO, We can rely on the is_fixed_role metadata. Currently, we are not utilizing it and not even updating it for fixed roles.
There was a problem hiding this comment.
Lets open internal jira to track this work.
| @@ -1992,7 +1992,7 @@ dumpBabelPhysicalDatabaseACLs(Archive *fout) | |||
| "\n SET LOCAL ROLE sysadmin;" | |||
| "\n FOR rolname, original_name IN (" | |||
| "\n SELECT a.rolname, a.orig_username FROM sys.babelfish_authid_user_ext a" | |||
| "\n WHERE orig_username IN ('dbo','db_accessadmin') AND" | |||
| "\n WHERE orig_username IN ('dbo','db_accessadmin','db_securityadmin') AND" | |||
There was a problem hiding this comment.
redeisgn/rethink this query so that we dont need to re-write this everytime
There was a problem hiding this comment.
This needs to be backward compatible, so this will be an interesting challenge
There was a problem hiding this comment.
Need @rishabhtanwar29 's opinion on this.
Deepesh125
reviewed
Oct 25, 2024
| @@ -53,9 +53,15 @@ typedef enum { | |||
| static babelfish_status bbf_status = NONE; | |||
|
|
|||
| static char *default_bbf_db_principals = | |||
There was a problem hiding this comment.
isnt this list the same as default_bbf_roles defined in other file?
Deepesh125
approved these changes
Oct 25, 2024
tanscorpio7
force-pushed
the
server-database-roles-4-x
branch
from
f5618f3 to
46ac851
Compare
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
Description This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved BABEL-5135 Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 1, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 5, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
that referenced
this pull request
Nov 15, 2024
Description Handle babelfish dump restore changes for fixed database role db_securityadmin Extension PR : amazon-aurora/babelfish_extensions#70 Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 15, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 15, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 15, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
thephantomthief
pushed a commit
that referenced
this pull request
Nov 20, 2024
Description Handle babelfish dump restore changes for fixed database role db_securityadmin Extension PR : amazon-aurora/babelfish_extensions#70 Signed-off-by: Harsh Lunagariya <[email protected]>
thephantomthief
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 20, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
thephantomthief
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 20, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
that referenced
this pull request
Dec 5, 2024
Description Handle babelfish dump restore changes for fixed database role db_securityadmin Extension PR : amazon-aurora/babelfish_extensions#70 Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 5, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
shardgupta
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
This commit adds support for db_securityadmin fixed database roles. Members of db_securityadmin can perform following operations within a particular database: create schema create database roles alter/drop user-defined database roles manage permissions via grant/revoke statements Engine Changes - amazon-aurora/postgresql_modified_for_babelfish#100 Issues Resolved [BABEL-5135] Signed-off-by: Harsh Lunagariya <[email protected]>
chxwang
pushed a commit
that referenced
this pull request
Dec 12, 2024
Description Handle babelfish dump restore changes for fixed database role db_securityadmin Extension PR : amazon-aurora/babelfish_extensions#70 Signed-off-by: Harsh Lunagariya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extension PR : amazon-aurora/babelfish_extensions#70
Issues Resolved
BABEL-5135
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.